Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
fieldToLlvmTypein class.ts had tworeturn "i8*"catch-alls that silently handled any unrecognized tsType.tsTypeToLlvm/tsTypeToLlvmForFieldin interface-struct-generator.ts silently returnedi8*for null/empty types.After
Both
fieldToLlvmTypesites now explicitly dispatch on known type categories (string, void, any/unknown/object, null/undefined/never, unions, inline objects, string literals, function types, LLVM types) before the remaining catch-all. Interface-struct-generator throws on null/empty types instead of silently returningi8*.No user-facing change. Internal refactor only.
Description
Part of #710 (eliminate silent-default dispatch). Fourth PR in series after #749, #750, #751. The
fieldToLlvmTypecatch-allreturn "i8*"is retained because the function can't distinguish interface names from truly unknown types without access to the interface struct generator — but the explicit dispatch narrows it to only interface/class name resolution.